[VL][Delta] Add native Delta DV reader support#12040
Open
malinjawi wants to merge 3 commits into
Open
Conversation
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
split/delta-dv-native-reader-pr
branch
from
1a16894 to
66ea460
Compare
Comment on lines
+59
to
+79
| struct DeltaProtocolInfo { | ||
| int32_t minReaderVersion; | ||
| int32_t minWriterVersion; | ||
| std::optional<std::vector<std::string>> readerFeatures; | ||
| std::optional<std::vector<std::string>> writerFeatures; | ||
|
|
||
| /// Check if this protocol supports deletion vectors. | ||
| /// Returns true if: | ||
| /// - minReaderVersion >= 3 | ||
| /// - minWriterVersion >= 7 | ||
| /// - 'deletionVectors' is in readerFeatures | ||
| bool supportsDeletionVectors() const { | ||
| if (minReaderVersion < 3 || minWriterVersion < 7) { | ||
| return false; | ||
| } | ||
| if (!readerFeatures.has_value()) { | ||
| return false; | ||
| } | ||
| return std::find(readerFeatures->begin(), readerFeatures->end(), "deletionVectors") != readerFeatures->end(); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
In which case do we need this struct and the validation logics? Won't we only use native DV features when the Java side feature exists?
|
|
||
| namespace { | ||
|
|
||
| class DeltaConnectorTest : public ::testing::Test { |
Member
There was a problem hiding this comment.
Can we also add some test cases that are more E2E? E.g., read a file with a passed-in DV, then verify whether the unwanted rows are filtered out?
Comment on lines
+68
to
+70
| void loadSerializedDeletionVector( | ||
| std::string_view serializedPayload, | ||
| std::optional<uint64_t> expectedCardinality = std::nullopt); |
Member
There was a problem hiding this comment.
Can we add comments explaining expectedCardinality?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR is the second step in the split Delta deletion-vector (DV) stack, following #12001.
It adds the native Velox-side Delta DV reader layer that consumes the roaring bitmap payload facilities introduced by #12001, without adding the JVM-side Delta scan metadata handoff yet.
Main changes:
DeltaDeletionVectorReaderto load materialized Delta DV payloads usingRoaringBitmapArrayDeltaSplitReaderto validate DV protocol/statistics metadata and apply row-index filtering semanticsThis PR is intentionally native-reader only:
Those pieces will be added in follow-up split PRs.
issue #11901.
How was this patch tested?
Added focused native test coverage in:
cpp/velox/compute/delta/tests/DeltaConnectorTest.cppcpp/velox/compute/delta/tests/DeltaSplitTest.cppcpp/velox/compute/delta/tests/DeltaDeletionVectorReaderTest.cppCovered cases:
RoaringBitmapArrayValidation run:
malinjawi/incubator-gluten:mainon the combined PR2 branch: all checks passed after rerunning two infra-flaky jobsgit diff --check upstream/main...HEAD/opt/homebrew/opt/llvm@15/bin/clang-formatover changed C++ filesWas this patch authored or co-authored using generative AI tooling?
Generated-by: IBM BOB